Skip to content

feat(chat): Surface terminal model errors in chat#929

Merged
hazeone merged 1 commit intomainfrom
cursor/model-error-surface-1
Apr 28, 2026
Merged

feat(chat): Surface terminal model errors in chat#929
hazeone merged 1 commit intomainfrom
cursor/model-error-surface-1

Conversation

@hazeone
Copy link
Copy Markdown
Contributor

@hazeone hazeone commented Apr 28, 2026

Summary

Avoid the chat is always thinking after provider is error.

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other

Validation

Checklist

  • I ran relevant checks/tests locally.
  • I updated docs if behavior or interfaces changed.
  • I verified there are no unrelated changes in this PR.

Co-authored-by: Haze <hazeone@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4294012f3e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

"title": "Execution Graph",
"branchLabel": "branch",
"thinkingLabel": "Thinking",
"errorLabel": "Error",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add the runError.title locale key

The chat UI now renders t('runError.title') for terminal model failures, but this commit only adds executionGraph.errorLabel/runErrorLabel/modelErrorTitle keys in locale files. Because runError.title is missing, users will see the raw i18n key (runError.title) instead of a human-readable label whenever a run error is shown. Please add a consistent runError.title translation (or update the component to use an existing key) across locales.

Useful? React with 👍 / 👎.

@hazeone hazeone merged commit 9d3a59d into main Apr 28, 2026
6 checks passed
@hazeone hazeone deleted the cursor/model-error-surface-1 branch April 28, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants