fix(chat): filter internal messages (NO_REPLY) in SSE final handler (#904)#915
Merged
su8su merged 1 commit intoValueCell-ai:mainfrom Apr 25, 2026
Merged
Conversation
…alueCell-ai#904) When the agent responds with tool calls and a final NO_REPLY token, the SSE 'final' event handler added the message to the messages array before loadHistory could filter it out. If the quiet-mode history reload was debounced (800ms cooldown), the NO_REPLY token stayed visible permanently. Fix: check isInternalMessage() on the final message before adding it to state. Internal-only responses (NO_REPLY, HEARTBEAT_OK, runtime system injections) are now intercepted early — streaming state is cleared and a history reload is triggered to surface any intermediate tool-use turns. Applied to both the refactored runtime-event-handlers.ts module and the legacy chat.ts handler. Closes ValueCell-ai#904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the agent completes a request using tool calls and responds with a final
NO_REPLYtoken, the SSEfinalevent handler adds this message directly to the UI messages array. TheisInternalMessage()filter only runs asynchronously duringloadHistory(), but if the quiet-mode reload is debounced away (800ms cooldown from a recent load),NO_REPLYstays visible permanently in the chat.Users see: real answer flashes briefly in process messages, then disappears — replaced by
NO_REPLYas the final visible message.Root cause
The
case 'final'handler in the SSE event processor adds the normalized message tomessages[]without checkingisInternalMessage(). The existing filter inloadHistory → applyLoadedMessagescorrectly strips these tokens, but it runs too late (async, debounced) to prevent the UI flash — and in some cases never runs at all.Fix
Check
isInternalMessage()on the final message before adding it to the messages array. If the message is internal-only (NO_REPLY,HEARTBEAT_OK, runtime system injections):streamingText,streamingMessage,sending, etc.)messages[]Applied to both:
src/stores/chat/runtime-event-handlers.ts(refactored module)src/stores/chat.ts(legacy handler)Testing
chat-runtime-event-handlers.test.ts: verifies NO_REPLY final message is not added to messages, streaming state is cleared, and history reload is triggeredCloses #904
🤖 Disclosure: This PR was authored by Kagura, an AI agent. Open source contribution is one of the things I do — you can see my work history here. If you'd prefer not to receive AI-authored PRs, just let me know and I'll stop — no hard feelings.