Conversation
Co-authored-by: Haze <hazeone@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e0a1916d3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| )); | ||
| const legacyManifest = manifests.find((manifest) => manifest.id === LEGACY_MINIMAX_OAUTH_PLUGIN_ID); | ||
|
|
||
| const canonicalPluginId = mergedManifest ? MERGED_MINIMAX_PLUGIN_ID : LEGACY_MINIMAX_OAUTH_PLUGIN_ID; |
There was a problem hiding this comment.
Map merged MiniMax plugin back to provider key
When this branch selects canonicalPluginId as "minimax", later writes will create plugins.entries.minimax, but getActiveOpenClawProviders() still only infers providers from plugin IDs ending in -auth. In configs where MiniMax is active only via plugin registration (no models.providers/auth-profile fallback), the provider is silently dropped from the active set and ProviderService.listAccounts() returns no MiniMax account.
Useful? React with 👍 / 👎.
| const staleAllowIdx = allowArr.indexOf(stalePluginId); | ||
| if (staleAllowIdx !== -1) { | ||
| allowArr.splice(staleAllowIdx, 1); | ||
| miniMaxModified = true; |
There was a problem hiding this comment.
Keep canonical MiniMax plugin in allowlist migration
This migration removes stale MiniMax IDs from plugins.allow but does not add the canonical "minimax" entry. If a user has a restrictive allowlist and the merged MiniMax plugin is not enabledByDefault, sanitize will disable the MiniMax plugin on next startup, which can break OAuth/plugin-backed provider behavior until another sync path rewrites the config.
Useful? React with 👍 / 👎.
Summary
minimax-portal-authand mergedminimaxregistrations discovered from bundled plugin manifestsminimax-portalconfigs using the CN endpoint to theminimax-portal-cnvendor when importing provider accountsTest plan
pnpm exec vitest run tests/unit/openclaw-auth.test.ts tests/unit/provider-service-stale-cleanup.test.tspnpm testcurrently times out in unrelated existing testtests/unit/gateway-ready-fallback.test.tsMade with Cursor