Conversation
…light theme Markdown tables rendered inside assistant reply bubbles previously showed a filled (muted) background on the header row, which looked heavy on the light theme. Make the header background transparent and bump the font weight to 700 in light mode. Dark theme retains the original muted background so the header row stays visually distinct against the dark bubble. Adds an Electron E2E spec that seeds a session with a markdown table, switches to the light theme, asserts the computed header styles and captures a screenshot of the rendered table. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…nglish fixtures - Replace the Chinese seeded chat content in the markdown-table-header spec with English equivalents so the fixture is locale-neutral. - Save the screenshot via testInfo.outputPath(...) and attach it to the Playwright report instead of writing directly to /opt/cursor/artifacts, which does not exist on the macOS E2E runner and caused ENOENT failures. The spec still mirrors the file to /opt/cursor/artifacts when the directory exists (for cloud-agent artifact uploads), but silently ignores missing parent dirs. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Markdown tables rendered inside assistant reply bubbles showed a filled (muted) background on the header row, which looked heavy on the light theme. This PR makes the header background transparent and bumps the font weight to
700in light mode. Dark theme retains the original muted background so the header row stays visually distinct against the dark bubble.Reply bubble markdown table header in light theme (transparent background, bold text)
Change is isolated to
.prose thinsrc/styles/globals.css; no renderer/main IPC changes.Related Issue(s)
N/A
Type of Change
Validation
pnpm run lintpnpm run typecheckpnpm run build:vitetests/e2e/chat-table-header-light.spec.tsseeds a chat session with a markdown table, switches to light theme, asserts computed header styles (background-color: rgba(0, 0, 0, 0),font-weight >= 700) and attaches a screenshot of the rendered table to the Playwright report viatestInfo.outputPath(...)so it works on both Linux (cloud) and macOS runners.xvfb-run -a pnpm exec playwright test tests/e2e/chat-table-header-light.spec.ts— passes on Linux.Checklist
To show artifacts inline, enable in settings.