HasEvolvingItem returns invslot::SLOT_AUGMENT_GENERIC_RETURN (1001) when the evolving unique ID is found on an augment rather than a standalone item. Passing that sentinel to GetItem always returns null, silently dropping toggle and transfer operations for augment-hosted evolving items.

Note: this only affects the edge case where the augment itself is tagged as an evolving item. Normal items that have augments socketed into them, and regular evolving item XP gain, are unaffected.

Description

InventoryProfile::HasEvolvingItem can return invslot::SLOT_AUGMENT_GENERIC_RETURN (1001) when the evolving unique ID is found on an augment slotted inside a parent item. This value is not a real inventory slot, so any subsequent call to GetItem(slot_id) returns null. Previously, the toggle and XP transfer functions would silently fail in this scenario — no error was logged, no message was shown to the player, and the operation was dropped without explanation.

This fix explicitly detects the augment sentinel return value and rejects the operation with a clear log entry (and a user-facing message where appropriate), rather than allowing it to silently null-deref.

Changes

• DoEvolveItemToggle: Explicit SLOT_AUGMENT_GENERIC_RETURN guard with log entry — augment-based evolving items are not supported for toggling.
• SendEvolveXPWindowDetails: Same guard, silent early return (preview window, no user action committed).
• DoEvolveTransferXP: Same guard with user-facing Chat::Red message and log entry explaining augment-based evolving items are not supported for XP transfer.

if (slot_id == EQ::invslot::SLOT_AUGMENT_GENERIC_RETURN) {
    LogEvolveItem(
        "Character ID <green>[{}] toggle evolve item unique id <yellow>[{}] is an augment-based evolving item; "
        "augment-based evolving items are not supported for toggling",
        CharacterID(),
        in->unique_id
    );
    return;
}

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing

Validated logic by code review; augment-based evolving items now produce clear diagnostic output instead of a silent null-deref failure path. Normal items with augments socketed into them and regular evolving item XP gain (ProcessEvolvingItem) are unaffected by this change.

Clients tested: N/A (server-side logic only)

Checklist

• I have tested my changes
• I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
• I own the changes of my code and take responsibility for the potential issues that occur

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.