[Code Review Fixes] Claude Code Review & Fixes for Evolving items PR#100
Merged
Valorith merged 2 commits intocodex/evolving-item-review-fixes-masterfrom Mar 22, 2026
Merged
Conversation
- Fix ALL_EXP branch logic: raid/solo exp rates were unreachable when
ALL_EXP was set because it short-circuited to group rate. Restructured
to check raid first, then group, then solo fallback.
- Move progression >= 100 checks inside mob null guards for
SPECIFIC_MOB_RACE, SPECIFIC_ZONE_ID, and NUMBER_OF_KILLS cases to
prevent unnecessary queue additions when mob is null.
- Fix copy-paste log message in NUMBER_OF_KILLS case: was incorrectly
logged as "Type 4 Specific Zone ID" instead of "Type 5 Number of Kills".
- Guard .at("evolve") calls in SetEvolveEquipped with .contains() check
to prevent std::out_of_range if called before timer is created.
https://claude.ai/code/session_01VgYPW4cYy3mzh17LKFQs58
There was a problem hiding this comment.
Pull request overview
This PR addresses several correctness and robustness issues in the evolving item system, primarily around experience subtype selection, kill/zone/race processing guards, and safer timer access.
Changes:
- Fix
ALL_EXPsubtype branching so raid/group/solo experience rates are applied in the intended priority order (raid → group → solo). - Ensure progression-complete items are only queued when the relevant mob-dependent condition is actually processed (avoids unnecessary queue additions when
mobis null). - Prevent
std::out_of_rangeinSetEvolveEquippedby guardingGetTimers().at("evolve")with.contains().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
zone/client_evolving_items.cpp |
Corrects experience subtype branching, tightens mob-guarded progression queueing, and adjusts a kill-type log message. |
common/item_instance.cpp |
Adds a safety guard around "evolve" timer access to avoid .at() throwing when the timer is not present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
749e606
into
codex/evolving-item-review-fixes-master
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01VgYPW4cYy3mzh17LKFQs58
Description
Please include a summary of the changes and the related issue (Why is this change necessary). Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Testing
Attach images and describe testing done to validate functionality.
Clients tested:
Checklist