Skip to content

codec: fix "prefix of array attribute must be an object name" #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eine merged 3 commits into from
Mar 26, 2020
Merged

codec: fix "prefix of array attribute must be an object name" #635

eine merged 3 commits into from
Mar 26, 2020

Conversation

@eine
Copy link
Collaborator

@eine eine commented Mar 22, 2020 •
edited
Loading

A change in v0.37 made some of the tests in VUnit fail. #631 fixed some of them, but four are still failing:

tests/acceptance/test_external_run_scripts.py::TestExternalRunScripts::test_com_vhdl_2008
tests/acceptance/test_external_run_scripts.py::TestExternalRunScripts::test_data_types_vhdl_2002
tests/acceptance/test_external_run_scripts.py::TestExternalRunScripts::test_data_types_vhdl_2008
tests/acceptance/test_external_run_scripts.py::TestExternalRunScripts::test_data_types_vhdl_93

According to ghdl/ghdl#1152, this is something that needs to be fixed in VUnit's codebase.

In this PR, helper functions get_encoded_length, get_decoded_range_right and get_decoded_range_left are added. These replace existing helper vars range_left and range_right that were used for RivieraPRO.

To do:

  • Should these helper functions be defined elsewhere?
  • Do tests pass in RivieraPRO?

@eine eine requested a review from LarsAsplund March 22, 2020 20:26
@eine eine merged commit 3124d97 into VUnit:master Mar 26, 2020
@eine eine deleted the fix-codec branch March 26, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LarsAsplund LarsAsplund Awaiting requested review from LarsAsplund

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eine