Rework release procedure #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #316.
This PR is an attempt to rework the release procedure through Travis.
py36-docs. The deployment is only executed with tagged commits.tools/is_new_release.pyis renamed totools/new_release.pyand it is reworked:./tools/new_release.pylocally and thengit push v<version>to the main repository. The tag will fail/skip if it already exists, or if corresponding release notes are not found../tools/new_release.py 'check'will be executed before pushing a new version to PyPi. This job is only executed with tagged commits.Overall, instead of Travis guessing when a new release happened and having it push a tag to the git repo, the procedure is reversed. We tell Travis explicitly when we want a new release, and it will proceed accordingly.
The checks are the same, so tags ending with
rc0can be successfully pushed to GitHub and GitHub pages will be updated, but they will not be pushed to PyPi.Note that I did not test the deployment jobs in this PR because access tokens do not work in my fork.