Add python major #157
Merged
Add python major #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenguh
reviewed
Jan 10, 2021
Member
|
Looks good. As far as the run failed tests, maybe we can bind it to |
Contributor
Author
I like it. I'll modify accordingly. |
stevenguh
reviewed
Jan 12, 2021
marcoieni
reviewed
Jan 12, 2021
Member
|
Thank you Muscaw! This is great 😁 |
marcoieni
reviewed
Jan 12, 2021
marcoieni
reviewed
Jan 12, 2021
marcoieni
reviewed
Jan 12, 2021
Contributor
Author
|
I addressed the different comments, feel free to let me know if you see something else to change. |
stevenguh
approved these changes
Jan 14, 2021
Member
|
Thanks again Muscaw! 🚀 |
Contributor
Author
|
Thanks to you as well @marcoieni @stevenguh for the incredible work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some keybindings for Python major. (Fixes #149)
The Python major mode assume that the extension vscode-python is present.
The keybindings map the following features:
Not all keybindings found on the spacemacs python keybindings page could be mapped to the VSCode Python extension.
I also took the liberty of using a free slot in the test section to rerun failed tests (SPC m t x).
If you feel like it does not have its place here, please let me know and I'll remove it.
The feature to re-run failed tests is present in the vscode-python extension the Python major mode assumes is there.