Clojure keybindings for the Calva extension #154
Conversation
stevenguh
left a comment
There was a problem hiding this comment.
Thank you for submitting the changes. This looks very comprehensive. I haven't looked at the bindings closely but there are some consistency issues like capitalization, ordering, and formatting.
e0b50d4 to
104c07c
Compare
|
Thank you for the feedback. I have pushed an update to the PR that should resolve the concerns raised. Thank you. |
stevenguh
left a comment
There was a problem hiding this comment.
I think there are still some indentation and order issues. You can run npm run sort-bindings to sort and format the bindings.
104c07c to
53f1eb7
Compare
|
This is HUGE! Thank you for your effort. I expect our clojure community to do additional PRs or open issues once this is merged and they notice something wrong or they want to improve these key bindings :) |
53f1eb7 to
81cd833
Compare
|
The PR has been rebased onto the latest master. I have run the sort bindings script and made the suggested changes. |
|
Thank you for updating the PR. It looks great! |
81cd833 to
7f4f3c9
Compare
|
I found a duplicate key binding in the Structured editing menu, t and W were the same, so have removed W. |
calva.io is the defacto extension for Clojure development with VSCode Key bindings cover the key aspects of development - starting and connecting to a Clojure REPL - evaluating code in the REPL - structured editing - refactor commands - test runner Key bindings are added in the existing +Major section as conditionals based on languageId of Clojure. No key bindings are added outside of the +Major section. The clojure key bindings were added before go to presever the alphabetic ordering of the major mode configuration section Key bindings are sorted using the `npm run sort-bindings` command, organising them in alphabetic order, placing lower case keys before upper case. before the key bindings Key bindings tested with the latest version of VSpaceCode and Calva extensions. User guide documentation will be added in a separate commit.
7f4f3c9 to
0f40fe2
Compare
|
Thank you all for your help with this PR, greatly appreciated. |
calva.io is the defacto extension for Clojure development with VSCode.
Add key binding in the existing +Major section as conditionals
based on languageId of Clojure. No key bindings are added outside of the +Major
section
Key bindings cover the key aspects of development
Key bindings are added in alphabetic order, placing them before the key bindings
for Go and Markdown.
Key bindings tested with the latest version of VSpaceCode and Calva extensions.
Relates to #153 #98