-
Notifications
You must be signed in to change notification settings - Fork 132
Markdown major mode #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown major mode #111
Conversation
|
That extension also shipped with some default shortcut (although limited to markdown doc), are those interfering in anyway? |
|
Not from what I can tell, this is just an abstraction on top of it (I didn't disable any default keybindings and they all seem to work just fine) |
|
@stevenguh RFAL |
|
That looks good to me. What you think, @marcoieni? |
|
This is great, I will see myself using it daily, thank you! Just a few notes:
|
|
Ignore point 2. I saw that they are the same commands for spacemacs. Sorry. |
|
After you've replaced spaces with tabs, you can update the changelog and it's ok to merge this. |
|
Hey all, apologies, I'll have this fixed up in a few days (currently on vacation, not near a computer). |
|
No worries. Thank you for letting us know and enjoy your vacation 😊 |
|
@marcoieni indentation converted to tabs. Apologies about that. My $0.02, in projects that I've set up at my job we set up pre-commit hooks that style code exactly the way that we need so that this isn't a problem that comes up (styling can be whatever you want while developing, but is forced to "conform" when committing) 🙂. In this case, I'd recommend something like Prettier to run when committing, and maybe just make a quick Makefile with a target Please let me know if you need me to modify anything else! |
|
Just FYI, the style of the package.json is enforced by Anyway, setting up prettier or something like that would definitely be a nice enhancement :) |
|
Oh woops, forgot to update the changelog, one sec! |
|
Okay should be good now, lmk if I missed anything! |
|
Thank you so much, this is awesome! 🚀 For the code style discussion I opened #114 |
Description
Closes #108.
Added menus and commands that made sense given what we have in the Markdown All in One extension. Surprisingly enough, there aren't really that many commands that the Markdown All in One extension provides, but I don't think we want to layer on a more extensions unless we have to.
One thing that came up when I was trying to put these together was that it'd be sweet if we could expand code snippets directly via vscode-which-key when when trying functionality that wasn't there, such as adding the
SPC m x kmapping that's in the Spacemacs Markdown layer for example. Without a way to expand code snippets directly, I didn't think there was any appropriate way to add that. Potential feature request?I referenced the Markdown layer for Spacemacs when trying to come up with where to put these mappings.
Checklist
CHANGELOG: