Skip to content

bump cxxopts#999

Merged
jcoupey merged 2 commits intoVROOM-Project:masterfrom
Orthae:bump-cxxopts
Sep 25, 2023
Merged

bump cxxopts#999
jcoupey merged 2 commits intoVROOM-Project:masterfrom
Orthae:bump-cxxopts

Conversation

@Orthae
Copy link
Copy Markdown
Contributor

@Orthae Orthae commented Sep 22, 2023

Issue

Fixes #997
I am not sure if it should go to master or to 1.13.1

Tasks

  • Update CHANGELOG.md (remove if irrelevant)
  • review

@jcoupey jcoupey merged commit 4fb5901 into VROOM-Project:master Sep 25, 2023
@jcoupey jcoupey added this to the v1.14.0 milestone Sep 25, 2023
@jcoupey
Copy link
Copy Markdown
Collaborator

jcoupey commented Sep 25, 2023

I am not sure if it should go to master or to 1.13.1

I merged to master since I don't feel we should do a patch release for this because:

  • the problem is not in this repo but in an upstream break;
  • our usage of cxxopts is consistent with bundled version at all times so everything works out of the box for any user following our instructions with submodules.

We're trying to keep things up to date and simple, but if users want to use custom versions of the dependencies, they have to somehow be prepared for custom adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error: no type named 'OptionException' in namespace 'cxxopts' issue

2 participants