Skip to content

Fix breaks location_index#937

Merged
jcoupey merged 6 commits intomasterfrom
fix/breaks-location-index
Jun 26, 2023
Merged

Fix breaks location_index#937
jcoupey merged 6 commits intomasterfrom
fix/breaks-location-index

Conversation

@jcoupey
Copy link
Copy Markdown
Collaborator

@jcoupey jcoupey commented Jun 22, 2023

Issue

fixes #877

Tasks

  • Make Step::location optional
  • Only serialize location[_index] based on existing value
  • While we're at it refactor various job_type members to be optional instead of holding dummy JOB_TYPE::SINGLE values
  • Update CHANGELOG.md
  • review

@jcoupey jcoupey added this to the v1.14.0 milestone Jun 22, 2023
@jcoupey jcoupey merged commit d9166d2 into master Jun 26, 2023
@jcoupey jcoupey deleted the fix/breaks-location-index branch June 26, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaks steps have meaningless location_index values in output

1 participant