Skip to content

Restrict speed_factor in the range (0, 5]#592

Merged
jcoupey merged 3 commits intoVROOM-Project:masterfrom
krashish8:fix/591-speed-factor-range
Oct 14, 2021
Merged

Restrict speed_factor in the range (0, 5]#592
jcoupey merged 3 commits intoVROOM-Project:masterfrom
krashish8:fix/591-speed-factor-range

Conversation

@krashish8
Copy link
Copy Markdown
Contributor

@krashish8 krashish8 commented Oct 13, 2021

Issue

Fix #591

Tasks

  • Add check for speed_factor range
  • Update docs/API.md
  • Update CHANGELOG.md
  • review

Signed-off-by: Ashish Kumar <ashishkr23438@gmail.com>
Signed-off-by: Ashish Kumar <ashishkr23438@gmail.com>
Signed-off-by: Ashish Kumar <ashishkr23438@gmail.com>
@jcoupey jcoupey added this to the v1.11.0 milestone Oct 13, 2021
Copy link
Copy Markdown
Collaborator

@jcoupey jcoupey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jcoupey jcoupey merged commit 017af62 into VROOM-Project:master Oct 14, 2021
@jcoupey
Copy link
Copy Markdown
Collaborator

jcoupey commented Oct 14, 2021

I merged the branch in both master and release/1.11 so this will be included in the upcoming v1.11 release. Only change I performed upon merging is to remove the very specific mention on using speed_factor values with custom matrices. I feel it's enough to document the allowed range, then we could still refer to the previous discussions if one needs more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaling logic of speed_factor is flawed for high values

2 participants