Implement reading input from stdin#459
Conversation
|
Thanks for submitting a PR!
In that case the error will be caught down the line upon parsing so I think we can keep things that way. It would be consistent with the current behavior, both
I'm not sure to get the implications here but I'm not very familiar with this kind of stuff. In what situation would this be an improvement? |
Running vroom from a terminal without arguments would still print the help message (potentially helping new users) and running |
|
I think we can live with |
d315247 to
072bcc6
Compare
|
Alright, I added this change to the changelog. This is ready to merge, I think |
Issue
Fixes #457
Tasks
CHANGELOG.mdDescription
With these changes, vroom follows the following strategy for getting its input:
-i FILEoption was used, readFILEas inputstdinas inputPreviously vroom would display its help string in case 3. This degrades the experience for new users somewhat, since executing
vroomwithout any arguments won't appear to do anything until the user closesstdinwith^D, which then results in a cryptic json parsing exception.Alternatives to consider:
stdinas input ifstdinis not a tty (unsure how portableisattyis)stdinhas length 0 or is not valid json