Skip to content

Cleanup includes#426

Merged
jcoupey merged 3 commits intomasterfrom
enhancement/includes-cleanup
Jan 7, 2021
Merged

Cleanup includes#426
jcoupey merged 3 commits intomasterfrom
enhancement/includes-cleanup

Conversation

@jcoupey
Copy link
Copy Markdown
Collaborator

@jcoupey jcoupey commented Jan 5, 2021

Issue

Fixes #425. Since this PR is likely to touch many files anyway, I'm also taking the opportunity to update the copyright date to 2021.

Tasks

  • Run iwyu on the codebase
  • Try and apply suggested changes
  • Update copyright from 2020 to 2021
  • Update CHANGELOG.md
  • review

@jcoupey
Copy link
Copy Markdown
Collaborator Author

jcoupey commented Jan 5, 2021

The CI builds are passing so I think that's about it. We can be pretty confident on not breaking anything when using gcc or clang on Ubuntu. It would be nice to have some feedback on other systems though, as we've seen some unexpected build errors related to includes in the past. Yes I do mean MacOS.

@jcoupey jcoupey merged commit 1365703 into master Jan 7, 2021
@jcoupey jcoupey deleted the enhancement/includes-cleanup branch January 7, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Includes cleanup

1 participant