Skip to content

Remove unused breaks_travel_margin members from TWRoute and associated code#1295

Merged
jcoupey merged 3 commits intoVROOM-Project:masterfrom
nir-ben-menachem:remove-unused-break-travel-margins
Oct 15, 2025
Merged

Remove unused breaks_travel_margin members from TWRoute and associated code#1295
jcoupey merged 3 commits intoVROOM-Project:masterfrom
nir-ben-menachem:remove-unused-break-travel-margins

Conversation

@nir-ben-menachem
Copy link
Copy Markdown
Contributor

@nir-ben-menachem nir-ben-menachem commented Oct 12, 2025

Tasks

  • Update CHANGELOG.md (remove if irrelevant)
  • review

@jcoupey
Copy link
Copy Markdown
Collaborator

jcoupey commented Oct 15, 2025

Thanks for submitting a PR. It looks like this data was stored for some purpose at one point, but in the final implementation we only rely on the margin values computed on the fly during checks.

Copy link
Copy Markdown
Collaborator

@jcoupey jcoupey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just pushed a commit for sonarcloud suggestions.

@jcoupey jcoupey merged commit b31662a into VROOM-Project:master Oct 15, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants