Update deprecated asio io_service and query#1279
Update deprecated asio io_service and query#1279jcoupey merged 1 commit intoVROOM-Project:masterfrom
Conversation
jcoupey
left a comment
There was a problem hiding this comment.
Thanks for spotting this and submitting a PR! The changes look quite straightforward, I'm just wondering if you've been able to test the ssl version somehow?
|
I've been able to compile and use the version of this PR but I don't believe to have hit these specific code path in the executions. Are there tests I could run to verify ? |
|
If you've been using locally, chances are you've been doing the requests over http so you went through I guess the easiest test would be to run an existing demo endpoint from a routing engine that supports https, e.g. routing.openstreetmap.de for OSRM. |
On ArchLinux, I get asio v1.34.2 in which
io_serviceandqueryare not defined anymore so I getThis PR fixes the two issues.