Skip to content

Code duplication in routing logic #1184

@jcoupey

Description

@jcoupey

The sonarcloud checks at #1137 report some code duplication in the routing logic. It is related to various routing wrappers inheriting from HttpWrapper defining various virtual functions in exactly the same way in headers.

While I don't really see how this could be avoided in general, it turns out that here the actual implementation is identical in many cases for both OrsWrapper and OsrmRoutedWrapper. So we should move the "default" implementations to HttpWrapper and only override for ValhallaWrapper.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions