The sonarcloud checks at #1137 report some code duplication in the routing logic. It is related to various routing wrappers inheriting from HttpWrapper defining various virtual functions in exactly the same way in headers.
While I don't really see how this could be avoided in general, it turns out that here the actual implementation is identical in many cases for both OrsWrapper and OsrmRoutedWrapper. So we should move the "default" implementations to HttpWrapper and only override for ValhallaWrapper.
The sonarcloud checks at #1137 report some code duplication in the routing logic. It is related to various routing wrappers inheriting from
HttpWrapperdefining various virtual functions in exactly the same way in headers.While I don't really see how this could be avoided in general, it turns out that here the actual implementation is identical in many cases for both
OrsWrapperandOsrmRoutedWrapper. So we should move the "default" implementations toHttpWrapperand only override forValhallaWrapper.