Skip to content

fix: enable rules-of-hooks#9308

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/enable-rules-of-hooks
Dec 16, 2025
Merged

fix: enable rules-of-hooks#9308
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/enable-rules-of-hooks

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Dec 16, 2025

Описание

  • включаем линтер хуков
  • выносим предупреждение usePatchChildren подальше от React.cloneElement
  • удаляем eslint-plugin-react-compiler (он стал частью правил хуков)

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner December 16, 2025 16:03
@SevereCloud SevereCloud self-assigned this Dec 16, 2025
@SevereCloud SevereCloud added this to VKUI Dec 16, 2025
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 16, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 16, 2025 •
edited
Loading

size-limit report 📦

Path Size
JS 393.51 KB (+0.01% 🔺)
JS (gzip) 120.7 KB (+0.01% 🔺)
JS (brotli) 99.88 KB (-0.1% 🔽)
JS import Div (tree shaking) 811 B (0%)
CSS 370.28 KB (0%)
CSS (gzip) 45.89 KB (0%)
CSS (brotli) 36.32 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 16, 2025 •
edited
Loading

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 16, 2025 •
edited
Loading

📊 Найдены изменения в собранных файлах: Отчет

Commit f4b4192

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 16, 2025 •
edited
Loading

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9308/f4b41922bf3f7ad4b321fee9a2d0a2c463310d5e/pkg/@vkontakte/vkui/_pkg.tgz

Commit f4b4192

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (bb1376e) to head (f4b4192).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9308   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         416      416           
  Lines       11217    11219    +2     
  Branches     4223     4223           
=======================================
+ Hits        10657    10659    +2     
  Misses        560      560
Flag Coverage Δ
unittests 95.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 16, 2025
@SevereCloud SevereCloud added this to the v8.0.0 milestone Dec 16, 2025
@SevereCloud SevereCloud force-pushed the SevereCloud/fix/enable-rules-of-hooks branch from e8c60b5 to f4b4192 Compare December 16, 2025 16:30
inomdzhon
inomdzhon approved these changes Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

а эта задаче не - close #6919?

@SevereCloud
Copy link
Copy Markdown
Contributor Author

SevereCloud commented Dec 16, 2025

Для начала я бы затестил работоспособность компонентов

@SevereCloud SevereCloud merged commit a0982f4 into master Dec 16, 2025
28 of 29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/enable-rules-of-hooks branch December 16, 2025 17:06
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Dec 16, 2025
@inomdzhon inomdzhon linked an issue Dec 17, 2025 that may be closed by this pull request
[Tech] Поддержка React компилятора #6919
Closed
1 task
@inomdzhon inomdzhon mentioned this pull request Dec 17, 2025
Closed
1 task
@inomdzhon inomdzhon removed this from the v8.0.0 milestone Dec 17, 2025
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tech] Поддержка React компилятора

2 participants

@SevereCloud @inomdzhon