Skip to content

feat: remove modal root deprecated types#9278

Merged
EldarMuhamethanov merged 1 commit intomasterfrom
e.muhamethanov/remove-modal-types
Dec 10, 2025
Merged

feat: remove modal root deprecated types#9278
EldarMuhamethanov merged 1 commit intomasterfrom
e.muhamethanov/remove-modal-types

Conversation

@EldarMuhamethanov
Copy link
Copy Markdown
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Dec 10, 2025

  • Release notes

Описание

Удалил неиспользуемы и устаревшие типы в модалках

Release notes

BREAKING CHANGE

  • Удален устаревший HOC withModalRootContext

@EldarMuhamethanov EldarMuhamethanov added this to the v8.0.0 milestone Dec 10, 2025
@EldarMuhamethanov EldarMuhamethanov self-assigned this Dec 10, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 10, 2025 08:03
@EldarMuhamethanov EldarMuhamethanov mentioned this pull request Dec 10, 2025
Closed
16 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 10, 2025

size-limit report 📦

Path Size
JS 425.18 KB (-0.08% 🔽)
JS (gzip) 128.63 KB (-0.06% 🔽)
JS (brotli) 105.23 KB (-0.04% 🔽)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 372.2 KB (0%)
CSS (gzip) 46.05 KB (0%)
CSS (brotli) 36.47 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 10, 2025

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 10, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 68871aa

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 10, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9278/68871aa0b71f360c2da369499787cd5f52146e31/pkg/@vkontakte/vkui/_pkg.tgz

Commit 68871aa

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (5a0f0fc) to head (68871aa).
⚠️ Report is 38 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9278      +/-   ##
==========================================
- Coverage   95.03%   95.03%   -0.01%     
==========================================
  Files         418      416       -2     
  Lines       11204    11199       -5     
  Branches     4209     4212       +3     
==========================================
- Hits        10648    10643       -5     
  Misses        556      556
Flag Coverage Δ
unittests 95.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EldarMuhamethanov EldarMuhamethanov merged commit 8d18332 into master Dec 10, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/remove-modal-types branch December 10, 2025 08:49
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Dec 10, 2025
@inomdzhon inomdzhon added the v8 label Dec 19, 2025
@vkcom-publisher
Copy link
Copy Markdown
Contributor

vkcom-publisher commented Mar 31, 2026

✅ v8.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SevereCloud SevereCloud SevereCloud approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels

breaking-change cmp:modal-root

Projects

VKUI
Status: ✅ Done

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@EldarMuhamethanov @vkcom-publisher @SevereCloud @inomdzhon