Skip to content

fix(View): rm ref, use Map#9259

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/View/rm-ref-use-Map
Dec 8, 2025
Merged

fix(View): rm ref, use Map#9259
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/View/rm-ref-use-Map

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Dec 5, 2025

Описание

ref нельзя использовать во время рендера, меняем объект на мапу

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner December 5, 2025 12:37
@SevereCloud SevereCloud added this to the v8.0.0 milestone Dec 5, 2025
@SevereCloud SevereCloud added this to VKUI Dec 5, 2025
@SevereCloud SevereCloud self-assigned this Dec 5, 2025
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

size-limit report 📦

Path Size
JS 426.25 KB (-0.02% 🔽)
JS (gzip) 129.09 KB (-0.01% 🔽)
JS (brotli) 105.49 KB (+0.06% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 371.88 KB (0%)
CSS (gzip) 46 KB (0%)
CSS (brotli) 36.43 KB (0%)

@SevereCloud SevereCloud removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 17b1335

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9259/17b1335409ab09d1835a0c3f7eb17b803046df2e/pkg/@vkontakte/vkui/_pkg.tgz

Commit 17b1335

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.09%. Comparing base (3f0d065) to head (17b1335).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/View/ViewInfinite.tsx 88.88% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9259   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         419      419           
  Lines       11206    11206           
  Branches     4212     4212           
=======================================
  Hits        10656    10656           
  Misses        550      550
Flag Coverage Δ
unittests 95.09% <94.44%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud merged commit be478c9 into master Dec 8, 2025
28 of 29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/View/rm-ref-use-Map branch December 8, 2025 07:27
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Dec 8, 2025
@inomdzhon inomdzhon mentioned this pull request Dec 17, 2025
Closed
1 task
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
@inomdzhon inomdzhon removed this from the v8.0.0 milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

No one assigned

Labels

cmp:root cmp:view

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SevereCloud @inomdzhon