Skip to content

test(Popover): Cannot reassign variables declared outside of the component#9249

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/test/Popover/ref-in-effect
Dec 2, 2025
Merged

test(Popover): Cannot reassign variables declared outside of the component#9249
SevereCloud merged 1 commit intomasterfrom
SevereCloud/test/Popover/ref-in-effect

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

Описание

Пишем во внешнюю переменную из эффекта

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner December 2, 2025 09:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

size-limit report 📦

Path Size
JS 426.4 KB (0%)
JS (gzip) 129.12 KB (0%)
JS (brotli) 105.5 KB (0%)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.88 KB (0%)
CSS (gzip) 45.92 KB (0%)
CSS (brotli) 36.4 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

✅ Изменений в собранных файлах нет

Commit 1f09a4e

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9249/1f09a4ec80148cd4cb8e2aacbf41badd97b945e0/pkg/@vkontakte/vkui/_pkg.tgz

Commit 1f09a4e

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.08%. Comparing base (883557c) to head (1f09a4e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9249   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         419      419           
  Lines       11211    11211           
  Branches     4215     4215           
=======================================
  Hits        10660    10660           
  Misses        551      551           
Flag Coverage Δ
unittests 95.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inomdzhon inomdzhon added this to VKUI Dec 2, 2025
@inomdzhon inomdzhon moved this to 👀 In Review in VKUI Dec 2, 2025
@SevereCloud SevereCloud merged commit 220504e into master Dec 2, 2025
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/test/Popover/ref-in-effect branch December 2, 2025 10:42
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 2, 2025
@inomdzhon inomdzhon linked an issue Dec 17, 2025 that may be closed by this pull request
1 task
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech] Поддержка React компилятора

2 participants