Skip to content

fix(Tappable): pointerDelayTimers use ref#9244

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/Tappable/pointerDelayTimers-use-ref
Dec 1, 2025
Merged

fix(Tappable): pointerDelayTimers use ref#9244
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/Tappable/pointerDelayTimers-use-ref

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Dec 1, 2025

Описание

Используем ref

Modifying a value previously passed as an argument to a hook is not allowed. Consider moving the modification before calling the hook.

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner December 1, 2025 10:05
@SevereCloud SevereCloud self-assigned this Dec 1, 2025
@SevereCloud SevereCloud added this to the v8.0.0 milestone Dec 1, 2025
@SevereCloud SevereCloud added this to VKUI Dec 1, 2025
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

size-limit report 📦

Path Size
JS 426.48 KB (+0.02% 🔺)
JS (gzip) 129.13 KB (+0.01% 🔺)
JS (brotli) 105.48 KB (-0.07% 🔽)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.88 KB (0%)
CSS (gzip) 45.92 KB (0%)
CSS (brotli) 36.4 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

e2e tests

Playwright Report

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.08%. Comparing base (a67fd16) to head (49ecab6).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/Tappable/Ripple.tsx 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9244   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         419      419           
  Lines       11211    11212    +1     
  Branches     4215     4216    +1     
=======================================
+ Hits        10660    10661    +1     
  Misses        551      551
Flag Coverage Δ
unittests 95.08% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9244/49ecab66f1906fd7f831976dcc7abef0f84ca349/pkg/@vkontakte/vkui/_pkg.tgz

Commit 49ecab6

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 49ecab6

@SevereCloud SevereCloud removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 1, 2025
inomdzhon
inomdzhon reviewed Dec 1, 2025
View reviewed changes
@SevereCloud SevereCloud merged commit dc65a79 into master Dec 1, 2025
28 of 29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Tappable/pointerDelayTimers-use-ref branch December 1, 2025 15:04
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Dec 1, 2025
@inomdzhon inomdzhon linked an issue Dec 17, 2025 that may be closed by this pull request
[Tech] Поддержка React компилятора #6919
Closed
1 task
@inomdzhon inomdzhon mentioned this pull request Dec 17, 2025
Closed
1 task
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
@inomdzhon inomdzhon removed this from the v8.0.0 milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

No one assigned

Labels

cmp:tappable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tech] Поддержка React компилятора

2 participants

@SevereCloud @inomdzhon