Skip to content

test(Gallery): fix ref#9243

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/test/Gallery/fix-ref
Dec 1, 2025
Merged

test(Gallery): fix ref#9243
SevereCloud merged 1 commit intomasterfrom
SevereCloud/test/Gallery/fix-ref

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

Описание

React refs are values that are not needed for rendering. Refs should only be accessed outside of render, such as in event handlers or effects. Accessing a ref value (the `current` property) during render can cause your component not to update as expected (https://react.dev/reference/react/useRef).

/Users/d.suvorov/Documents/VKCOM/VKUI/packages/vkui/src/components/Gallery/Gallery.test.tsx:39:49
  37 |   getRef: React.Ref<HTMLDivElement>;
  38 | }) => (
> 39 |   <div style={{ fontSize: '72px', width }} ref={rest.getRef}>
     |                                                 ^^^^^^^^^^^ Cannot access ref value during render
  40 |     {children}
  41 |   </div>
  42 | );  react-hooks/refs

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner December 1, 2025 07:57
@SevereCloud SevereCloud added this to the v8.0.0 milestone Dec 1, 2025
@SevereCloud SevereCloud added this to VKUI Dec 1, 2025
@SevereCloud SevereCloud self-assigned this Dec 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

size-limit report 📦

Path Size
JS 426.42 KB (0%)
JS (gzip) 129.12 KB (0%)
JS (brotli) 105.55 KB (0%)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.88 KB (0%)
CSS (gzip) 45.92 KB (0%)
CSS (brotli) 36.4 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

✅ Изменений в собранных файлах нет

Commit c029705

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.08%. Comparing base (a67fd16) to head (c029705).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9243   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         419      419           
  Lines       11211    11211           
  Branches     4215     4215           
=======================================
  Hits        10660    10660           
  Misses        551      551           
Flag Coverage Δ
unittests 95.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9243/c029705e0368db75ec997350875590c4eb266b1e/pkg/@vkontakte/vkui/_pkg.tgz

Commit c029705

@SevereCloud SevereCloud merged commit df18522 into master Dec 1, 2025
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/test/Gallery/fix-ref branch December 1, 2025 11:40
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Dec 1, 2025
@inomdzhon inomdzhon linked an issue Dec 17, 2025 that may be closed by this pull request
1 task
@inomdzhon inomdzhon removed this from the v8.0.0 milestone Dec 17, 2025
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech] Поддержка React компилятора

2 participants