Skip to content

fix: useFocusWithin ref in render#9230

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/useFocusWithin-ref-in-render
Dec 1, 2025
Merged

fix: useFocusWithin ref in render#9230
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/useFocusWithin-ref-in-render

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Nov 28, 2025

Описание

Читать ref во время рендера нельзя. Также во время превого рендера будет false так как компонент не должен быть вмонтирован

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner November 28, 2025 13:10
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Nov 28, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2025

size-limit report 📦

Path Size
JS 426.94 KB (-0.01% 🔽)
JS (gzip) 129.28 KB (-0.01% 🔽)
JS (brotli) 105.8 KB (+0.02% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.88 KB (0%)
CSS (gzip) 45.92 KB (0%)
CSS (brotli) 36.4 KB (0%)

@SevereCloud SevereCloud removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Nov 28, 2025
@SevereCloud SevereCloud self-assigned this Nov 28, 2025
@SevereCloud SevereCloud added this to VKUI Nov 28, 2025
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Nov 28, 2025
@SevereCloud SevereCloud added this to the v8.0.0 milestone Nov 28, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 376fc53

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9230/376fc53940042a7630d3a660d1f9f04c844b3642/pkg/@vkontakte/vkui/_pkg.tgz

Commit 376fc53

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.05%. Comparing base (4b1e43c) to head (376fc53).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9230      +/-   ##
==========================================
- Coverage   95.05%   95.05%   -0.01%     
==========================================
  Files         420      420              
  Lines       11244    11243       -1     
  Branches     4225     4224       -1     
==========================================
- Hits        10688    10687       -1     
  Misses        556      556
Flag Coverage Δ
unittests 95.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud merged commit 6ceef0a into master Dec 1, 2025
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/useFocusWithin-ref-in-render branch December 1, 2025 07:22
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 1, 2025
@inomdzhon inomdzhon linked an issue Dec 17, 2025 that may be closed by this pull request
[Tech] Поддержка React компилятора #6919
Closed
1 task
@inomdzhon inomdzhon mentioned this pull request Dec 17, 2025
Closed
1 task
@inomdzhon inomdzhon removed this from the v8.0.0 milestone Dec 17, 2025
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tech] Поддержка React компилятора

2 participants

@SevereCloud @inomdzhon