feat(ModalPage,ModalCard,ModalRoot): add prop disableModalOverlay#8815
Merged
EldarMuhamethanov merged 8 commits intomasterfrom Aug 8, 2025
Merged
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8815 +/- ##
=======================================
Coverage 95.95% 95.96%
=======================================
Files 419 419
Lines 12171 12189 +18
Branches 4049 4060 +11
=======================================
+ Hits 11679 11697 +18
Misses 492 492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8815/5862de94f83279ebcd1d0290654ad3a1b1df1443/pkg/@vkontakte/vkui/_pkg.tgzCommit 5862de9 |
inomdzhon
previously approved these changes
Jul 31, 2025
BlackySoul
reviewed
Jul 31, 2025
SevereCloud
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disableModalOverlayвModalRoot/ModalPage/ModalCard#8071Описание
Нужно добавить свойство
disableModalOverlayдляModalCard,ModalPage,ModalRoot. При использовании этот флага должно отключаться отображение и взаимодействие с фоном.Изменения
disableModalOverlayдляModalCard,ModalPage,ModalRootModalOverlay, а также дляModalOutletдобавил свойствоpointer-events: none, чтобы можно было кликать сквозьRelease notes
Улучшения
ModalCard,ModalPage,ModalRootдобавлено свойствоdisableModalOverlay, которое позволяет отключить отображение фона модалки