Skip to content

feat(Banner): fix text colors with imageTheme using#8777

Merged
EldarMuhamethanov merged 2 commits intomasterfrom
e.muhamethanov/8758/fix-banner-text-colors
Jul 22, 2025
Merged

feat(Banner): fix text colors with imageTheme using#8777
EldarMuhamethanov merged 2 commits intomasterfrom
e.muhamethanov/8758/fix-banner-text-colors

Conversation

@EldarMuhamethanov
Copy link
Copy Markdown
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Jul 21, 2025 •
edited
Loading

  • e2e-тесты
  • Дизайн-ревью
  • Release notes

Описание

Сейчас цвета текстов в компоненте Banner отличаются от дизайна. Из-за этого цвета текстов при использовании свойства imageTheme ведут себя не так как описано в JSDoc этого свойства.

Изменения

  • Привел цвета текстов в Banner к цветам из дизайна
  • Привел цвет extraSubtitle к цвету subtitle

Release notes

Исправления

  • Banner: Поправлены цвета текстов при использовании с mode="image" и imageTheme. Также теперь цвет extraSubtitle соответствует subtitle

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner July 21, 2025 14:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 21, 2025 •
edited
Loading

size-limit report 📦

Path Size
JS 415.16 KB (0%)
JS (gzip) 123.65 KB (0%)
JS (brotli) 101.47 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 350.23 KB (-0.02% 🔽)
CSS (gzip) 43.44 KB (-0.02% 🔽)
CSS (brotli) 34.62 KB (-0.04% 🔽)

inomdzhon
inomdzhon previously approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅💅💅

@inomdzhon
Copy link
Copy Markdown
Contributor

inomdzhon commented Jul 21, 2025

@EldarMuhamethanov в релиз ноут ещё про extraSubtitle стоит упомянуть, что теперь цвет соответствует subtitle

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 21, 2025 •
edited
Loading

e2e tests

Playwright Report

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (b049e5b) to head (0d9cfaf).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8777   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         418      418           
  Lines       12133    12133           
  Branches     4033     4033           
=======================================
  Hits        11643    11643           
  Misses        490      490
Flag Coverage Δ
unittests 95.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 21, 2025 •
edited
Loading

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8777/0d9cfaf5ecd73ca63fbd595955aa3854a14ed9a2/pkg/@vkontakte/vkui/_pkg.tgz

Commit 0d9cfaf

@inomdzhon inomdzhon requested a review from a team July 22, 2025 07:40
@EldarMuhamethanov EldarMuhamethanov merged commit 074c6d3 into master Jul 22, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8758/fix-banner-text-colors branch July 22, 2025 15:03
This was referenced Jul 25, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@SevereCloud SevereCloud SevereCloud approved these changes

+1 more reviewer

@martishevskiy martishevskiy martishevskiy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@EldarMuhamethanov @inomdzhon @SevereCloud @martishevskiy