Skip to content

feat(Button): add elevation#5275

Closed
SevereCloud wants to merge 1 commit intomasterfrom
SevereCloud/feat/Button/add-elevation
Closed

feat(Button): add elevation#5275
SevereCloud wants to merge 1 commit intomasterfrom
SevereCloud/feat/Button/add-elevation

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Jun 14, 2023 •
edited
Loading

Добавляем свойство установки тени для кнопки

image

@SevereCloud
feat(Button): add elevation
6a51b6b 
Добавляем возможность добавлять тень для кнопки
@SevereCloud SevereCloud requested a review from a team as a code owner June 14, 2023 14:57
@SevereCloud SevereCloud self-assigned this Jun 14, 2023
@SevereCloud SevereCloud added this to the v5.6.0 milestone Jun 14, 2023
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 14, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6a51b6b:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 14, 2023

👀 Docs deployed

Commit 6a51b6b

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 14, 2023

size-limit report 📦

Path Size
JS 304.77 KB (+0.05% 🔺)
JS (gzip) 89.41 KB (+0.06% 🔺)
JS (brotli) 74.13 KB (+0.11% 🔺)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 272.48 KB (+0.18% 🔺)
CSS (gzip) 35.58 KB (+0.14% 🔺)
CSS (brotli) 28.2 KB (+0.12% 🔺)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 14, 2023

e2e tests

Playwright Report

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.03 🎉

Comparison is base (cac8d42) 81.69% compared to head (6a51b6b) 81.73%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5275      +/-   ##
==========================================
+ Coverage   81.69%   81.73%   +0.03%     
==========================================
  Files         283      283              
  Lines        9483     9486       +3     
  Branches     3016     3018       +2     
==========================================
+ Hits         7747     7753       +6     
+ Misses       1736     1733       -3
Flag Coverage Δ
a11ytests ?
unittests 81.73% <66.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vkui/src/components/Button/Button.tsx 97.95% <66.66%> (-2.05%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

inomdzhon
inomdzhon reviewed Jun 15, 2023
View reviewed changes
packages/vkui/src/components/Button/Button.tsx
before?: React.ReactNode;
after?: React.ReactNode;
loading?: boolean;
elevation?: Elevation;
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может dropShadow? А то elevation слишком уж абстрактно

Copy link
Copy Markdown
Contributor Author

@SevereCloud SevereCloud Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://m3.material.io/styles/elevation/overview

Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon Jun 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У матириала Elevation отвечает за уровень элемента, так скажем, за его z-index. Тень выступает это второстепенный атрибут элемента.

В нашем случае, как я понял, дизайн хочет чисто визуальный акцент придать кнопке.

Можем на дизайн-синке обсудить про Elevation, а то сейчас применим важный паттерн с неполной его реализацией

@SevereCloud SevereCloud marked this pull request as draft June 19, 2023 10:57
@SevereCloud SevereCloud removed this from the v5.6.0 milestone Jun 19, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jun 27, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 4, 2023

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-actions github-actions bot closed this Jul 4, 2023
@SevereCloud SevereCloud deleted the SevereCloud/feat/Button/add-elevation branch August 2, 2023 08:45
@SevereCloud SevereCloud mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon left review comments

Assignees

@SevereCloud SevereCloud

Labels

cmp:button pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности type:feature

Projects

VKUI
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SevereCloud @inomdzhon