Skip to content

refactor: remove template literal css modules#4357

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/issue3415
Mar 1, 2023
Merged

refactor: remove template literal css modules#4357
SevereCloud merged 1 commit intomasterfrom
SevereCloud/issue3415

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Feb 28, 2023 •
edited
Loading

Удаляем динамическое использование css modules

@SevereCloud
refactor: remove template literal css modules
b9ef81c 
Удаляем динамическое использования css modules

- closed #3415
@SevereCloud SevereCloud requested a review from a team as a code owner February 28, 2023 07:30
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Feb 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b9ef81c:

Sandbox Source
VKUI TypeScript Configuration

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 28, 2023 •
edited
Loading

Codecov Report

Base: 69.50% // Head: 69.65% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (b9ef81c) compared to base (75a1e48).
Patch coverage: 94.11% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4357      +/-   ##
==========================================
+ Coverage   69.50%   69.65%   +0.14%     
==========================================
  Files         376      376              
  Lines        8064     8119      +55     
  Branches     2853     2900      +47     
==========================================
+ Hits         5605     5655      +50     
- Misses       2459     2464       +5
Flag Coverage Δ
a11ytests 3.22% <10.71%> (+0.02%) ⬆️
e2e-chromium-android-dark 49.92% <81.17%> (+0.26%) ⬆️
e2e-chromium-android-light 49.92% <81.17%> (+0.26%) ⬆️
e2e-chromium-vkcom-dark 48.64% <82.35%> (+0.29%) ⬆️
e2e-chromium-vkcom-light 48.64% <82.35%> (+0.21%) ⬆️
e2e-firefox-vkcom-dark 48.55% <82.35%> (+0.21%) ⬆️
e2e-firefox-vkcom-light 48.55% <82.35%> (+0.21%) ⬆️
e2e-webkit-ios-dark 50.11% <82.35%> (+0.18%) ⬆️
e2e-webkit-ios-light 50.11% <82.35%> (+0.18%) ⬆️
e2e-webkit-vkcom-dark 48.61% <82.35%> (+0.21%) ⬆️
e2e-webkit-vkcom-light 48.64% <82.35%> (+0.24%) ⬆️
unittests 65.12% <77.64%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/ActionSheetItem/ActionSheetItem.tsx 100.00% <ø> (ø)
packages/vkui/src/components/Badge/Badge.tsx 100.00% <ø> (ø)
...es/vkui/src/components/BaseGallery/BaseGallery.tsx 2.72% <0.00%> (-0.02%) ⬇️
packages/vkui/src/components/CardGrid/CardGrid.tsx 100.00% <ø> (ø)
...ages/vkui/src/components/CellButton/CellButton.tsx 100.00% <ø> (ø)
.../vkui/src/components/FocusVisible/FocusVisible.tsx 100.00% <ø> (ø)
packages/vkui/src/components/Gradient/Gradient.tsx 100.00% <ø> (ø)
packages/vkui/src/components/Header/Header.tsx 97.61% <ø> (ø)
...i/src/components/HorizontalCell/HorizontalCell.tsx 86.66% <ø> (ø)
...ponents/HorizontalScroll/HorizontalScrollArrow.tsx 87.50% <ø> (ø)
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 28, 2023

size-limit report 📦

Path Size
JS 296.99 KB (-2.41% 🔽)
JS (gzip) 87.36 KB (-1.48% 🔽)
JS (brotli) 72.36 KB (-1.38% 🔽)
JS import Div (tree shaking) 2.4 KB (0%)
CSS 271.17 KB (0%)
CSS (gzip) 34.77 KB (0%)
CSS (brotli) 27.64 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 28, 2023

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4357/

eugpoloz
eugpoloz reviewed Mar 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@eugpoloz eugpoloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может, заодно добавить линтер, который за темплейты в классах будет по рукам бить?

Но такое лучше отдельной задачей, поэтому аппрув, ехехе 😉

@SevereCloud
Copy link
Copy Markdown
Contributor Author

SevereCloud commented Mar 1, 2023

Может, заодно добавить линтер, который за темплейты в классах будет по рукам бить?

Но такое лучше отдельной задачей, поэтому аппрув, ехехе 😉

Да, нужно будет. Для начала на уровне сборки будет бить по рукам

@SevereCloud SevereCloud merged commit 637b849 into master Mar 1, 2023
@SevereCloud SevereCloud deleted the SevereCloud/issue3415 branch March 1, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BlackySoul BlackySoul BlackySoul approved these changes

+1 more reviewer

@eugpoloz eugpoloz eugpoloz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Epic][v5][CSS Modules] Заменить динамические вычисления свойств на мапы

4 participants

@SevereCloud @codecov-commenter @BlackySoul @eugpoloz