Skip to content

tech(css modules): rm unused adaptivity helpers#4274

Merged
inomdzhon merged 1 commit intomasterfrom
imirdzhamolov/issue4271/tech/rm-unused-adaptivity-helpers
Feb 17, 2023
Merged

tech(css modules): rm unused adaptivity helpers#4274
inomdzhon merged 1 commit intomasterfrom
imirdzhamolov/issue4271/tech/rm-unused-adaptivity-helpers

Conversation

@inomdzhon
Copy link
Copy Markdown
Contributor

- getHoverClassName()
- getPointerClassName()
- getViewHeightClassName()
@inomdzhon inomdzhon added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 17, 2023
@inomdzhon inomdzhon requested a review from a team as a code owner February 17, 2023 12:07
@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ce1a80:

Sandbox Source
VKUI TypeScript Configuration

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 17, 2023

Codecov Report

Base: 80.12% // Head: 80.03% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (3ce1a80) compared to base (2406558).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4274      +/-   ##
==========================================
- Coverage   80.12%   80.03%   -0.09%     
==========================================
  Files         272      269       -3     
  Lines        7159     7127      -32     
  Branches     2764     2753      -11     
==========================================
- Hits         5736     5704      -32     
  Misses       1423     1423              
Flag Coverage Δ
e2e-chromium-android-dark 49.62% <ø> (+0.08%) ⬆️
e2e-chromium-android-light 49.53% <ø> (-0.09%) ⬇️
e2e-chromium-vkcom-dark 48.21% <ø> (ø)
e2e-chromium-vkcom-light 48.21% <ø> (-0.09%) ⬇️
e2e-firefox-vkcom-dark 48.21% <ø> (ø)
e2e-firefox-vkcom-light 48.21% <ø> (ø)
e2e-webkit-ios-dark 49.80% <ø> (ø)
e2e-webkit-ios-light 49.80% <ø> (ø)
e2e-webkit-vkcom-dark 48.30% <ø> (ø)
e2e-webkit-vkcom-light 48.30% <ø> (+0.02%) ⬆️
unittests 75.60% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
JS 303.71 KB (0%)
JS (gzip) 88.34 KB (0%)
JS (brotli) 73.12 KB (0%)
JS import Div (tree shaking) 4.6 KB (0%)
CSS 271.14 KB (0%)
CSS (gzip) 34.79 KB (0%)
CSS (brotli) 27.67 KB (0%)

Copy link
Copy Markdown
Contributor

@eugpoloz eugpoloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link
Copy Markdown
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4274/

@inomdzhon inomdzhon merged commit 9dfa6f3 into master Feb 17, 2023
@inomdzhon inomdzhon deleted the imirdzhamolov/issue4271/tech/rm-unused-adaptivity-helpers branch February 17, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v5][CSS Modules] Удалить не используемые функции для адаптивности

4 participants