Skip to content

tech(css modules): rm getSizeXClassName()#4241

Merged
inomdzhon merged 1 commit intomasterfrom
imirdzhamolov/issue4240/tech/cssm-rm-dynamic-properties
Feb 16, 2023
Merged

tech(css modules): rm getSizeXClassName()#4241
inomdzhon merged 1 commit intomasterfrom
imirdzhamolov/issue4240/tech/cssm-rm-dynamic-properties

Conversation

@inomdzhon
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon requested a review from a team as a code owner February 15, 2023 18:09
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Feb 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd607de:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 15, 2023

size-limit report 📦

Path Size
JS 300.75 KB (+0.15% 🔺)
JS (gzip) 87.71 KB (+0.29% 🔺)
JS (brotli) 72.62 KB (+0.29% 🔺)
JS import Div (tree shaking) 4.6 KB (0%)
CSS 271.32 KB (0%)
CSS (gzip) 34.79 KB (0%)
CSS (brotli) 27.62 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4241/

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 15, 2023

Codecov Report

Base: 49.41% // Head: 75.17% // Increases project coverage by +25.75% 🎉

Coverage data is based on head (ca2bc44) compared to base (fb0efdc).
Patch coverage: 95.23% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4241       +/-   ##
===========================================
+ Coverage   49.41%   75.17%   +25.75%     
===========================================
  Files         270      272        +2     
  Lines        7056     7029       -27     
  Branches     2689     2643       -46     
===========================================
+ Hits         3487     5284     +1797     
+ Misses       3569     1745     -1824     
Flag Coverage Δ
e2e-webkit-ios-light ?
unittests 75.17% <95.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/vkui/src/components/CardScroll/CardScroll.tsx 29.41% <ø> (-2.02%) ⬇️
packages/vkui/src/components/AppRoot/AppRoot.tsx 91.02% <87.50%> (+7.02%) ⬆️
packages/vkui/src/components/CardGrid/CardGrid.tsx 100.00% <100.00%> (+85.71%) ⬆️
packages/vkui/src/components/Group/Group.tsx 89.28% <100.00%> (+0.39%) ⬆️
.../vkui/src/components/NativeSelect/NativeSelect.tsx 100.00% <100.00%> (ø)
packages/vkui/src/components/Panel/Panel.tsx 100.00% <100.00%> (ø)
...src/components/PanelHeaderBack/PanelHeaderBack.tsx 70.00% <100.00%> (+64.73%) ⬆️
...mponents/PanelHeaderContext/PanelHeaderContext.tsx 91.42% <100.00%> (+88.48%) ⬆️
...kui/src/components/SelectMimicry/SelectMimicry.tsx 100.00% <100.00%> (ø)
packages/vkui/src/components/SplitCol/SplitCol.tsx 93.33% <100.00%> (+90.00%) ⬆️
... and 175 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

SevereCloud
SevereCloud previously approved these changes Feb 15, 2023
@inomdzhon inomdzhon force-pushed the imirdzhamolov/issue4240/tech/cssm-rm-dynamic-properties branch from cf7fbe4 to ca2bc44 Compare February 15, 2023 22:18
SevereCloud
SevereCloud previously approved these changes Feb 16, 2023
BlackySoul
BlackySoul previously approved these changes Feb 16, 2023
@inomdzhon inomdzhon dismissed stale reviews from BlackySoul and SevereCloud via dd607de February 16, 2023 08:50
@inomdzhon inomdzhon force-pushed the imirdzhamolov/issue4240/tech/cssm-rm-dynamic-properties branch from ca2bc44 to dd607de Compare February 16, 2023 08:50
@inomdzhon inomdzhon added ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча and removed ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Feb 16, 2023
@inomdzhon inomdzhon merged commit d74cd4f into master Feb 16, 2023
@inomdzhon inomdzhon deleted the imirdzhamolov/issue4240/tech/cssm-rm-dynamic-properties branch February 16, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v5][CSS Modules] Отказаться от использования getSizeXClassName()

4 participants