Skip to content

swc#4189

Merged
SevereCloud merged 6 commits intomasterfrom
SevereCloud/swc
Mar 2, 2023
Merged

swc#4189
SevereCloud merged 6 commits intomasterfrom
SevereCloud/swc

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Feb 9, 2023

Избавился от бабеля, перешел на swc


@SevereCloud SevereCloud requested review from a team as code owners February 9, 2023 17:15
@SevereCloud SevereCloud marked this pull request as draft February 9, 2023 17:15
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Feb 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ef7d155:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2023

size-limit report 📦

Path Size
JS 294.39 KB (-0.91% 🔽)
JS (gzip) 85.92 KB (-1.67% 🔽)
JS (brotli) 71.21 KB (-1.54% 🔽)
JS import Div (tree shaking) 2.4 KB (+0.05% 🔺)
CSS 271.16 KB (0%)
CSS (gzip) 34.78 KB (0%)
CSS (brotli) 27.62 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2023

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4189/

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.14 🎉

Comparison is base (27e9c90) 78.67% compared to head (ef7d155) 80.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4189      +/-   ##
==========================================
+ Coverage   78.67%   80.82%   +2.14%     
==========================================
  Files         270      336      +66     
  Lines        7190     8955    +1765     
  Branches     2821     2955     +134     
==========================================
+ Hits         5657     7238    +1581     
- Misses       1533     1717     +184     
Flag Coverage Δ
a11ytests 4.19% <ø> (+0.38%) ⬆️
e2e-chromium-android-dark 52.35% <ø> (+2.42%) ⬆️
e2e-chromium-android-light 52.26% <ø> (+2.33%) ⬆️
e2e-chromium-vkcom-dark 51.07% <ø> (+2.49%) ⬆️
e2e-chromium-vkcom-light 51.07% <ø> (+2.49%) ⬆️
e2e-firefox-vkcom-dark 50.98% <ø> (+2.40%) ⬆️
e2e-firefox-vkcom-light 50.98% <ø> (+2.40%) ⬆️
e2e-webkit-ios-dark 52.48% <ø> (+2.37%) ⬆️
e2e-webkit-ios-light 52.48% <ø> (+2.37%) ⬆️
e2e-webkit-vkcom-dark 51.04% <ø> (+2.41%) ⬆️
e2e-webkit-vkcom-light 51.07% <ø> (+2.41%) ⬆️
unittests 76.87% <ø> (+3.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/src/components/ModalRoot/useModalRootContext.tsx 0.00% <0.00%> (-100.00%) ⬇️
...kui/src/components/ModalRoot/ModalRootAdaptive.tsx 50.00% <0.00%> (-50.00%) ⬇️
packages/vkui/src/components/Textarea/Textarea.tsx 55.55% <0.00%> (-34.45%) ⬇️
.../vkui/src/components/CalendarTime/CalendarTime.tsx 62.50% <0.00%> (-25.00%) ⬇️
...nts/ActionSheet/ActionSheetDefaultIosCloseItem.tsx 25.00% <0.00%> (-25.00%) ⬇️
packages/vkui/src/components/Banner/Banner.tsx 79.54% <0.00%> (-20.46%) ⬇️
...ages/vkui/src/components/FormStatus/FormStatus.tsx 83.33% <0.00%> (-16.67%) ⬇️
...ages/vkui/src/components/SimpleCell/SimpleCell.tsx 80.48% <0.00%> (-16.29%) ⬇️
packages/vkui/src/components/RichCell/RichCell.tsx 84.61% <0.00%> (-15.39%) ⬇️
...es/vkui/src/components/Placeholder/Placeholder.tsx 85.71% <0.00%> (-14.29%) ⬇️
... and 312 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SevereCloud SevereCloud force-pushed the SevereCloud/swc branch 5 times, most recently from 576b345 to 5cf3770 Compare February 16, 2023 19:36
@SevereCloud SevereCloud force-pushed the SevereCloud/swc branch 3 times, most recently from d58c39c to 64b3010 Compare February 22, 2023 08:09
@SevereCloud SevereCloud marked this pull request as ready for review February 22, 2023 08:10
inomdzhon
inomdzhon previously approved these changes Feb 22, 2023
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пушка!!! 🔥

BlackySoul
BlackySoul previously approved these changes Feb 28, 2023
Copy link
Copy Markdown
Contributor

@eugpoloz eugpoloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@SevereCloud SevereCloud merged commit b4a4f57 into master Mar 2, 2023
@SevereCloud SevereCloud deleted the SevereCloud/swc branch March 2, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Перейти на SWC

6 participants