Skip to content

fix tooltip e2e tests#3272

Merged
stoope merged 11 commits intomasterfrom
fix-tooltip-e2e
Sep 14, 2022
Merged

fix tooltip e2e tests#3272
stoope merged 11 commits intomasterfrom
fix-tooltip-e2e

Conversation

@stoope
Copy link
Copy Markdown
Contributor

@stoope stoope commented Sep 13, 2022

Для скриншотных тестов задан размер viewport width: 800, height: 600, из-за этого некоторые тултипы не влазят и срабатывает автоопределение положения.
Сделал вычисление viewport в зависимости от контента

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Sep 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83ab521:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 13, 2022

size-limit report 📦

Path Size
JS 258.49 KB (0%)
JS (gzip) 77.69 KB (0%)
JS (brotli) 65.51 KB (0%)
JS, unstable 31.58 KB (0%)
CSS 290.58 KB (0%)
CSS (gzip) 39.25 KB (0%)
CSS (brotli) 31.23 KB (0%)
CSS, unstable 1.22 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/3272/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 13, 2022

Changed screenshots

textarea-fits-size-to-content-1
tooltip-android-light-1
tooltip-ios-light-1
tooltip-vkcom-light-1

Code coverage

lines3866 / 496477.88%
statements3936 / 506377.74%
functions836 / 106678.42%
branches3620 / 498972.55%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 83ab521

@stoope stoope marked this pull request as ready for review September 14, 2022 08:17
@stoope stoope requested a review from a team as a code owner September 14, 2022 08:17
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subnavigationbutton-android-light-1 обрезался

image

@stoope
Copy link
Copy Markdown
Contributor Author

stoope commented Sep 14, 2022

@SevereCloud done

@stoope stoope merged commit 9e1a006 into master Sep 14, 2022
@stoope stoope deleted the fix-tooltip-e2e branch September 14, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Некорректно отрисовывается Tooltip на скриншотном тесте

2 participants