Skip to content

refactor: Выделить модульный CSS и добавить линтеры#1639

Closed
thoughtspile wants to merge 6 commits intomasterfrom
infra/lint-modular-css
Closed

refactor: Выделить модульный CSS и добавить линтеры#1639
thoughtspile wants to merge 6 commits intomasterfrom
infra/lint-modular-css

Conversation

@thoughtspile
Copy link
Copy Markdown
Contributor

@thoughtspile thoughtspile commented May 27, 2021

Продолжаем плавно делать стили модульными:

  • Отмечаем модульные стили как .m.css (нашлось 29 компонентов)
  • Добавляем линтер, который проверяет что все стили из *.m.css правда модульные
  • Импортим из JS только модульные стили

Ожидаемый результат — в итоговом CSS поменялся только порядок модульных стилей.

@thoughtspile thoughtspile requested a review from a team as a code owner May 27, 2021 16:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 27, 2021

size-limit report 📦

Path Size
JS 46.26 KB (0%)
JS, unstable 11.31 KB (0%)
CSS 27.66 KB (+0.91% 🔺)
CSS, unstable 547 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/1639/

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 213530e:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 27, 2021

Code coverage

lines2126 / 360758.94%
statements2168 / 368658.82%
functions484 / 79760.73%
branches1241 / 283043.85%

Generated by 🚫 dangerJS against 752b121

ArthurStam
ArthurStam previously approved these changes May 27, 2021
@thoughtspile thoughtspile force-pushed the infra/lint-modular-css branch from 752b121 to 213530e Compare June 1, 2021 15:17
@SevereCloud SevereCloud deleted the infra/lint-modular-css branch January 25, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants