WIP: VKUI-48: Подключать CSS в JS отдельно в каждом компоненте#1335
Closed
thoughtspile wants to merge 11 commits intomasterfrom
Closed
WIP: VKUI-48: Подключать CSS в JS отдельно в каждом компоненте#1335thoughtspile wants to merge 11 commits intomasterfrom
thoughtspile wants to merge 11 commits intomasterfrom
Conversation
71ddcc5 to
c41a0c0
Compare
Contributor
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/1335/ |
Contributor
|
Contributor
size-limit report 📦
|
6a82045 to
e97f4ac
Compare
4c9e856 to
0002069
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad19d32:
|
This was referenced Mar 26, 2021
This was referenced May 24, 2021
Merged
Contributor
Author
|
пр умёр и поедет по чуть чуть в ближайший год |
Contributor
|
@thoughtspile почему? |
Contributor
Author
Потому что у нас не атомарные стили и есть шанс огрести очень тонких багов из-за порядка импорта компонентов в конечном аппе |
Contributor
|
Не понял, если нужны атомарные так давайте сделаем |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dist/cssmimport '@vkontakte/vkui'->import '@vkontakte/vkui/dist/cssm'/cssmcreate-vk-mini-app— 75% (26 -> 7К)WIP:
unstable.cssпопали транзитивные стили изvkui.cssvar(--duration)в.PullToRefresh__spinner--on .PullToRefresh__spinner-path