Fixed identifier highlighting#62
Merged
TimWhiting merged 2 commits intoFeb 11, 2024
Merged
Conversation
matthewnitschke
commented
Feb 11, 2024
Comment on lines
+11
to
+17
| (program | ||
| (ERROR | ||
| (final_builtin) | ||
| (identifier) | ||
| (type_identifier) | ||
| (type_arguments | ||
| (type_identifier))) |
Contributor
Author
There was a problem hiding this comment.
This change was a bit surprising, nothing in this area was actually updated
My current theory is that this is the cause of running tree-sitter generate on the latest version (older versions successfully passed this test)
Collaborator
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm new to writing tree-sitter parsers, so please correct me if this is an incorrect change.
All identifiers were being tagged as
@variable.builtin. Looking at some of the documentation provided by nvim,@variable.builtinshould be reserved for variables provided by the language (sothis.in dart)Changes
(identifier)s are now tagged with@variableinstead of@variable.builtin(this)is now tagged as@variable.builtintree-sitter generateandtree-sitter build-wasmwith thetree-sittercliv0.20.9. This resulted in changes onmaster, leading me to think these were outdated from previous PRsNote
Running
tree-sitter generateonv0.20.9, now results in the following output, theseconflictscan probably be cleaned up in a later PR