Fix double loading of human model texture#22
Merged
illwieckz merged 1 commit intofor-0.56.0/syncfrom Feb 23, 2026
Merged
Conversation
The human IQM references the texture models/players/human_male/base which causes it to be loaded by itself, instead of as part of the models/players/human_male/body shader as is is normally used. The IQM materials for player models are not actually used because we always use skins, but the engine still loads them. On master, this means the human_male/base texture is loaded twice. (In 0.55.4 it is only loaded once, but the imageMinDimension in the shader is ignored. You can force the old behavior by setting r_allowImageParamMismatch.) Fix this by setting the IQM material to the shader models/players/human_male/body, so that we don't load a variant of the material that is never used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The human IQM references the texture models/players/human_male/base which causes it to be loaded by itself, instead of as part of the models/players/human_male/body shader as is is normally used. The IQM materials for player models are not actually used because we always use skins, but the engine still loads them. On master, this means the human_male/base texture is loaded twice. (In 0.55.4 it is only loaded once, but the imageMinDimension in the shader is ignored. You can force the old behavior by setting r_allowImageParamMismatch.)
Fix this by setting the IQM material to the shader models/players/human_male/body, so that we don't load a variant of the material that is never used.