using non blocking call if possible to generate randomness#963
Closed
devnexen wants to merge 2 commits intoUnvanquished:masterfrom
devnexen:master
Closed
using non blocking call if possible to generate randomness#963devnexen wants to merge 2 commits intoUnvanquished:masterfrom devnexen:master
devnexen wants to merge 2 commits intoUnvanquished:masterfrom
devnexen:master
Conversation
mbasaglia
reviewed
Oct 9, 2016
daemon/src/common/System.cpp
Outdated
| size_t bytes_written; | ||
| if (nacl_secure_random(dest, size, &bytes_written) != 0 || bytes_written != size) | ||
| Sys::Error("nacl_secure_random failed"); | ||
| #else |
Member
There was a problem hiding this comment.
Maybe it's more readable to have
///...
#elif defined(__linux__) && defined(HAS_GETRANDOM_SYSCALL)
//...
#elif defined(__linux__)
//...
#endif
Member
|
Seems like the error here is somewhere else? This looks ok to me. |
Member
|
@DolceTriade what error are you talking about? Also, OK to merge now (also @mbasaglia)? |
Member
|
TBH I'd just use |
Member
|
Hi @devnexen! The Dæmon Engine is now extracted from this source tree, you can find its dedicated repository there: Can you replay your pull request on this repository? Merci et bienvenue ! 😉 |
Contributor
Author
|
Sure :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.