Fix keynum_t binds in bind menu#3455
Merged
slipher merged 1 commit intoUnvanquished:masterfrom Feb 23, 2026
Merged
Conversation
A regression caused bindable key events not to be sent for any Keyboard::Key that can be translated to an RmlUi key. This is because the bindable key event started being disabled if the normal key event was consumed, but the normal key event was always consumed. This just affected keynum_t Key's since character ones are ignored anyway. Instead of sending both normal RmlUi key events and bindable key events all the time, send only bindable key events during key binding and only normal key events otherwise. This should be a more reliable design anyway since some keys such as Tab and Enter could be interpreted as ones for navigating the document. So now Escape for canceling a bind will be detected through the bindable key event instead of the normal key event. Fixes Unvanquished#3454.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression caused bindable key events not to be sent for any Keyboard::Key that can be translated to an RmlUi key. This is because the bindable key event started being disabled if the normal key event was consumed, but the normal key event was always consumed. This just affected keynum_t Key's since character ones are ignored anyway.
Instead of sending both normal RmlUi key events and bindable key events all the time, send only bindable key events during key binding and only normal key events otherwise. This should be a more reliable design anyway since some keys such as Tab and Enter could be interpreted as ones for navigating the document. So now Escape for canceling a bind will be detected through the bindable key event instead of the normal key event.
Fixes #3454.