Skip to content

Move most skeleton stuff to engine#3276

Merged
illwieckz merged 11 commits intofor-0.56.0/syncfrom
reaper/engine-skeleton/sync
Mar 22, 2026
Merged

Move most skeleton stuff to engine#3276
illwieckz merged 11 commits intofor-0.56.0/syncfrom
reaper/engine-skeleton/sync

Conversation

@VReaperV
Copy link
Copy Markdown
Contributor

@VReaperV VReaperV commented Jan 5, 2025

Engine-side pr: DaemonEngine/Daemon#1489.

@VReaperV VReaperV mentioned this pull request Jan 5, 2025
Merged
@VReaperV VReaperV force-pushed the reaper/engine-skeleton/sync branch 3 times, most recently from 1f637e2 to 3da55d7 Compare January 8, 2025 10:06
@VReaperV VReaperV mentioned this pull request Jan 10, 2025
Closed
@VReaperV VReaperV mentioned this pull request Jan 17, 2025
Open
@VReaperV VReaperV force-pushed the reaper/engine-skeleton/sync branch 3 times, most recently from 861c007 to 0f7bb62 Compare September 15, 2025 21:09
@VReaperV
Move skeleton building and blending to engine
582634f 
Also implement a render entity cache to avoid back-and-forth synchronisation. The cache is synchronised before particles and trails are processed because they can be attached to render entities.

.
@VReaperV VReaperV force-pushed the reaper/engine-skeleton/sync branch 2 times, most recently from db854df to 061fc47 Compare September 26, 2025 14:35
@VReaperV VReaperV force-pushed the reaper/engine-skeleton/sync branch 7 times, most recently from 1cd32d2 to 2652914 Compare December 29, 2025 00:05
@VReaperV VReaperV marked this pull request as ready for review December 29, 2025 00:09
@VReaperV VReaperV force-pushed the reaper/engine-skeleton/sync branch 4 times, most recently from 41c2547 to 55638ba Compare December 29, 2025 01:26
@VReaperV
Copy link
Copy Markdown
Contributor Author

VReaperV commented Dec 29, 2025

MacOS CI failure is unrelated.

@VReaperV
Copy link
Copy Markdown
Contributor Author

VReaperV commented Mar 22, 2026

What is "entity cache" for? I'm curious what could be cached since even buildables often have an idle animation so you have to re-blend the skeletons. Is it a bug that I get messages about negative entity numbers?

Cache add entities: centity: -120962256221037952 frame: 1 current entities: 0 last frame entities: 1 offset: 0 count: 1 new entities: 1

I have not been able to reproduce this bug so far. I changed cg_showEntityCacheUpdates to be an update rate in case that helps find a reproduction for it.

@slipher
Copy link
Copy Markdown
Contributor

slipher commented Mar 22, 2026

It is easy to reproduce for me. For example I started Spacetracks, spawned with a rifle and immediately started getting it.

@VReaperV
Copy link
Copy Markdown
Contributor Author

VReaperV commented Mar 22, 2026

Ah, it's the predicted player entity. Fixed now.

@VReaperV VReaperV force-pushed the reaper/engine-skeleton/sync branch 2 times, most recently from b8cb88a to 8c23ec7 Compare March 22, 2026 06:38
@VReaperV
Copy link
Copy Markdown
Contributor Author

VReaperV commented Mar 22, 2026

I've removed the submodule changes because apparently this pile of shit only checks submodule hashes and not their history.

@VReaperV VReaperV force-pushed the reaper/engine-skeleton/sync branch 2 times, most recently from cbe6e46 to b803ea4 Compare March 22, 2026 07:54
@VReaperV
Copy link
Copy Markdown
Contributor Author

VReaperV commented Mar 22, 2026

CI fails because it pulls for-0.56 instead of the correct engine branch.

slipher
slipher reviewed Mar 22, 2026
View reviewed changes
@illwieckz illwieckz force-pushed the reaper/engine-skeleton/sync branch 2 times, most recently from 3a04e6c to 16513fb Compare March 22, 2026 17:33
@illwieckz
Copy link
Copy Markdown
Member

illwieckz commented Mar 22, 2026 •
edited
Loading

I reworked the submodule commit thing. The game-side branch wasn't rebased on the latest for-0.56.0/sync branch and hence GitHub was rebasing it first (and then pulling it first), leading to git conflicts.

@illwieckz
Copy link
Copy Markdown
Member

illwieckz commented Mar 22, 2026

@slipher Is it OK to fix after the release the remaining things you reported?

@illwieckz illwieckz force-pushed the reaper/engine-skeleton/sync branch from 483954b to f91cea0 Compare March 22, 2026 17:46
@slipher
Copy link
Copy Markdown
Contributor

slipher commented Mar 22, 2026

Having the right license would be nice

@illwieckz
Copy link
Copy Markdown
Member

illwieckz commented Mar 22, 2026

We already have a lot of BSD stuff in game like the bot stuff.

The license being BSD isn't wrong by itself.

To me the only thing curious is that it says Daemon Source Code.

@slipher
Copy link
Copy Markdown
Contributor

slipher commented Mar 22, 2026

We already have a lot of BSD stuff in game like the bot stuff.

The license being BSD isn't wrong by itself.

To me the only thing curious is that it says Daemon Source Code.

Yeah that is what I said, it should say Unvanquished.

@illwieckz
EntityCache: rename Daemon as Unvanquished
dc392da 
This is Unvanquished source code, not Daemon source code.

Also, Dæmon Developers is an alias for Unvanquished Developers,
it's the exact same thing.
@illwieckz illwieckz force-pushed the reaper/engine-skeleton/sync branch from 9956761 to e3a3b85 Compare March 22, 2026 17:52
@illwieckz
Copy link
Copy Markdown
Member

illwieckz commented Mar 22, 2026

Though that “Daemon Developers” alias for “Unvanquished Developers” annoys me to begin with, that's the exact same thing, it's just an alias.

@illwieckz illwieckz force-pushed the reaper/engine-skeleton/sync branch from e3a3b85 to a961c5c Compare March 22, 2026 18:03
@illwieckz
Copy link
Copy Markdown
Member

illwieckz commented Mar 22, 2026

@VReaperV does everything looks good to you?

@slipher
Copy link
Copy Markdown
Contributor

slipher commented Mar 22, 2026

Well this is the gamelogic side so it should be Unvanquished developers anyway.

@illwieckz illwieckz force-pushed the reaper/engine-skeleton/sync branch from a961c5c to dc392da Compare March 22, 2026 22:35
@illwieckz illwieckz merged commit dc392da into for-0.56.0/sync Mar 22, 2026
8 of 10 checks passed
@VReaperV VReaperV deleted the reaper/engine-skeleton/sync branch March 25, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illwieckz illwieckz illwieckz approved these changes

@slipher slipher slipher left review comments

Assignees

No one assigned

Labels

A-Client A-Renderer T-Cleanup T-Improvement Improvement for an existing feature T-Performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VReaperV @slipher @illwieckz