Nudge beacons for human players a bit upwards so that the beacon isn't on their butt#3155
Merged
slipher merged 2 commits intoUnvanquished:masterfrom Oct 30, 2024
Merged
Conversation
Also moves TargetTeam higher up since it will be used in the next commit
Member
|
Code LGTM. |
|
Why are we moving the beacon away from the origin for humans but not for aliens? |
Member
|
related issue #3152
Aliens have no butts 😄 is there one that has strange beacon placement? |
VReaperV
reviewed
Oct 29, 2024
2b73e3e to
7d12ed3
Compare
Contributor
|
LGTM |
Contributor
Author
|
I had a look on the alien forms and I think it's fine as it. The goon can use a slight move up but that's it.
Can someone hit the merge button for me?
…On 29 October 2024 13:24:20 CET, slipher ***@***.***> wrote:
LGTM
--
Reply to this email directly or view it on GitHub:
#3155 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Comparison of proposed solution
Before:
After: