fix: changemap command not found#3134
Merged
cu-kai merged 1 commit intoUnvanquished:masterfrom Oct 22, 2024
Merged
Conversation
in some cases, the changemap command may not be found due to incorrect ordering of the array in sg_admin.cpp
|
Sorting stuff is my hobby. LGTM |
Member
|
Sorry thanks for fixing. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, the
changemapcommand may not be found due to incorrect ordering of the array in sg_admin.cppThis bug was found today on Bunker after the update.
I assume this wasn't found while testing #2960 as the server used to test it probably didn't have custom admin commands.
Thanks @sweet235 for spotting the error.