Early support of the Saigo toolchain#2862
Merged
Conversation
b798ab2 to
312035a
Compare
312035a to
02f8abd
Compare
Member
Author
|
First commit So only one commit is left. |
bfdf060 to
da64ec2
Compare
26 tasks
slipher
reviewed
Nov 20, 2024
CMakeLists.txt
Outdated
| DEPENDERS build) | ||
| foreach(NACL_VMS_PROJECT ${NACL_VMS_PROJECTS}) | ||
| ExternalProject_Add_Step(${NACL_VMS_PROJECT} cbse-trigger | ||
| COMMENT "Finished CBSE generation, ready to build NaCl" |
Contributor
There was a problem hiding this comment.
How about adding the project name in the comment so the message isn't identical every time?
de543df to
479c684
Compare
Contributor
|
LGTM |
0eb9068 to
d29e417
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: