Note that this PR does not include a BT action that make bots reload, as I remember that this action required some heavier modifications to work reliably.

I removed the commit that implements action resupply as it's already possible to do that with the current API, using changeGoal and moveToGoal actions.

I see it's been simplified a bit by removing goon barb support. Reducing the scope of the resupply score to a single responsibility (only poison rather than poison + barbs) resolves my concern about getting poison not always being feasible.

No, there is still barb support: if the bot have no need for poison (because it already have poison), then it still might go (or rather stay) at booster for ammo, this is what bool needAmmo = !( weapon->infiniteAmmo && weapon->maxAmmo == 0 ); is for: there is a need for ammo if either condition is met: no infinite ammo, or maxAmmo != 0. This means that melee attacks won't set needAmmo, but barbs (the only weapon which have regenerating ammo) will.

I think those commits represent almost all the resupply API I used in betterai, with the only exception of the action reload which triggers bugs in the memory system. Those bugs i've fixed too, but the changeset is huge and I would not consider it ready for merge. It works without known problems, but it does not completely fix bot's memory issues so I'm not happy with it and won't try to push that for now (but maybe I could extract few changes from there that fix some actual bugs in enemy detection? I'll think about it.).

I updated the comments as discussed on IRC, and added support for energy resupply near drills, as when I wrote this drills were not able to resupply energy weapons.

LGTM