Address range highlighting bug (Fixes #955)#972
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Thanks, @nicolasfranck. I see that selectCurrentTreeNode() contains a 4-year-old TODO comment which implies that the eventual plan was to eliminate the need for two separate select methods entirely... so if that refactoring eventually occurs, your proposed change would need to be undone. But if it's fixing problems in the meantime, it seems relatively harmless, given that it's updating the tree node using the appropriate method for the event that caused the tree node to change initially. However, I see that there are several other calls to selectCurrentTreeNode in other parts of the file, and I'm not sure if these might still have bugs related to ranges. If they do, those bugs might be harder to fix. In any case, bottom line: it seems unlikely to me that this fix makes things worse or causes new breakages, but I'm not sure if it fixes every problem related to the underlying problem. I'd love input from @edsilv if he has any memory of the context of this, but I'd be reasonably comfortable with approving and merging this fix if you need it resolved before Ed has a chance to respond. Feel free to follow up here if you need further action from my end. |
|
Danny and Alex have started to test this - thanks |
|
Tested using the manifest that was not working when choosing 'rang 4' from the index using this URL: https://universalviewer-git-fork-nicolasfranck-patch-2-mnemoscene.vercel.app/#?xywh=0%2C-86%2C10937%2C7389&cv=4&rid=https%3A%2F%2Fadore.ugent.be%2FIIIF%2Fmanifests%2Frange-test%2Franges%2Frange-test%253AR.4&iiifManifestId=https%3A%2F%2Fadore.ugent.be%2FIIIF%2Fmanifests%2Frange-test Evidence:
fix now shows 'range 4' is highlighted in blue |
demiankatz
left a comment
There was a problem hiding this comment.
I'm going to go ahead and approve this given the test evidence presented. I won't hit the merge button until @alexrostronbl confirms that all testing is complete, however. Please let me know!
|
Hi @demiankatz I can confirm that all testing is complete for this issue so please merge. I don't seem to have rights to do an official approval if this is needed - thanks |
Fixes #955
As noted in the issue, I do not know if this breaks other stuff,
i.e. data that is not shown in openseadragon.