Skip to content

Fix #970#971

Merged
demiankatz merged 1 commit into
UniversalViewer:devfrom
nicolasfranck:patch-1
Mar 14, 2024
Merged

Fix #970#971
demiankatz merged 1 commit into
UniversalViewer:devfrom
nicolasfranck:patch-1

Conversation

@nicolasfranck

Copy link
Copy Markdown
Contributor

Fixes #970

@codesandbox

codesandbox Bot commented Mar 14, 2024

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel

vercel Bot commented Mar 14, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 2:41pm

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nicolasfranck, this makes sense to me, and I have confirmed that it fixes the problem without breaking older manifests. (Obviously, my testing was not incredibly exhaustive, but enough to give me confidence in merging this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants