The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
universalviewer	Ready	Preview, Comment	Apr 20, 2026 4:21pm

@LanieOkorodudu is attempting to deploy a commit to the Universal Viewer Team on Vercel.

A member of the Team first needs to authorize it.

Thanks @demiankatz for taking time to look into this. I thought of adding specific assertion but I was hesitating to complicate things, but it's good you mentioned, I will implement your suggestion and I believe this will improve the test.

@demiankatz, I added a reset after each test to bring the viewer back to the main URL, since the tests change the viewer state (navigation, zoom, rotation, etc.).

This way each test starts from a clean state and doesn’t get affected by what happened in the previous one.

Not sure if this is the best approach, so I’d appreciate your feedback. Thanks

Thanks for the progress here, @LanieOkorodudu, this is coming along very well!

See below for a few comments, many to do with minor style issues. If you need help investigating the related tooling, please let me know and I'll be happy to help as time permits!

Thanks for the feedback, really appreciate it! I’ll dig into the tooling and let you know if I get stuck.

@demiankatz, I’ve implemented your suggestions for the next/previous navigation, zoom, rotation, and adjust image tests.

I also fixed the indentation issues and ran Prettier, hopefully everything is aligned properly now.
The next/previous tests now check the actual page values and confirm they change by 1 (with a small adjustment so it works when starting on the first page).
The zoom test now checks the xywh value instead of the full URL.
I also applied your suggestion for the rotation check and updated the adjust image test name.
let me know if I may have missed anything.

Thanks, @LanieOkorodudu, this is shaping up nicely. See below for a few comments, all along very similar lines.

A couple of other general things:

1.) We didn't complete the conversation above about a standard way to set/override the URL of the instance under test. That's not a problem that we need to solve here, though -- I'm happy to set it aside and figure it out in a separate PR later.

2.) I wonder if it's also adding assertions about the previous button being disabled on the first page -- while we're testing going forward and back, maybe some extra checks about the button enabling/disabling as appropriate would be worth adding for completeness.

Thanks for the feedback @demiankatz,

1. I’ve intentionally left the URL override as-is for now, and yes I’ll address that in a separate PR.
2. I’ve added some checks for the previous button so it’s disabled on the first page, enabled after going forward, and disabled again when returning.

I’ve also removed the null checks and made the assertions more specific.
For the cv values, I kept the expectations as 0 → 1 based on what I observed earlier, since it seems to be zero-based in the URL while the viewer shows page numbers starting from 1.

I also updated the rotation test to read the rotation from the viewer state instead of the URL, since the URL didn’t seem to reflect the rotation reliably.

Let me know if these changes address it or if I've made anything worse.

Thanks for the progress here, @LanieOkorodudu! I think this is almost ready to merge. See below for a few minor suggestions.

Thanks for the suggestions, Let me know if I missed anything.

Thanks, @LanieOkorodudu, this all looks good to me now. If you're comfortable taking this out of draft mode, I think we can merge it and then move on to the next batch of tests (assuming you have more in mind!).

Thanks @demiankatz I’ll take this out of draft mode and proceed with the merge. After that, I’ll start addressing the standard way to set or override the URL of the instance under test, as discussed previously, and incorporate additional tests as well.

merged, thanks for all the feedback @demiankatz.