Upgrade to OpenSeadragon 6.#1694
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@jamesmisson is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @jamesmisson, great work on getting OSD running!
I notice, however, that you have upgraded css-loader to v7, which breaks MediaElement image loading as discussed in #1293. Is the css-loader upgrade necessary to make OSD work? If so, that makes a solution to #1293 an even more urgent priority; if not, can you revert CSS loader to v5 until we find a fix?
|
Thanks @demiankatz , for some reason css-loader was giving me errors when I first updated OSD so I upgraded it, but I can't reproduce those errors now that I've put it back to v5.0.1 and it seems to be building here so it looks alright without the upgrade. |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @jamesmisson, this all seems to be working correctly for me now!
The question, of course, is whether we should merge this now for inclusion in RC4, or if we should wait until after the 4.3.0 release.
I'm a bit nervous about including such a big change in the new release without giving it a little time to bake. But on the other hand, this does fix some pretty significant known bugs with tile alignment, so it might be nice to have ASAP. Maybe we can discuss at tomorrow's standup; I won't merge in the meantime.
|
As discussed at today's stand-up, we will hold off on merging this until after the RC4 release. |
This updates OSD to version 6 and makes some necessary adjustments.
OSD 6 is more strictly typed so most of the changes are to accommodate that, including a new interface defined for UV's annotation rects which are now more complex than the native OSD rect type allows.
There was an issue with the spinner remaining after a page load on newer versions of OSD (discussed here #905 ) which I've got round by closing the spinner after the successful loading of all tiles, rather than using an event. I've also added a delay to the spinner so that it doesn't flash up between very brief page loads which feels cleaner.
The dependabot issue should be resolved once this is merged: #1703