Skip to content

Add missing labels to zoom buttons in PDF center panel (fixes #1346)#1542

Closed
demiankatz wants to merge 2 commits into
UniversalViewer:devfrom
FalveyLibraryTechnology:fix-1346
Closed

Add missing labels to zoom buttons in PDF center panel (fixes #1346)#1542
demiankatz wants to merge 2 commits into
UniversalViewer:devfrom
FalveyLibraryTechnology:fix-1346

Conversation

@demiankatz

Copy link
Copy Markdown
Contributor

This adds labels to address #1346.

@vercel

vercel Bot commented Oct 2, 2025

Copy link
Copy Markdown

@demiankatz is attempting to deploy a commit to the BL UV team Team on Vercel.

A member of the Team first needs to authorize it.

K8Sewell
K8Sewell previously approved these changes Oct 2, 2025
@demiankatz

Copy link
Copy Markdown
Contributor Author

Thanks, @K8Sewell! I'm going to hold off on merging this until the Vercel build becomes available. I'm not sure why the build suddenly requires BL approval, but I've just asked the steering group. I suspect this change is not intentional. :-)

@LanieOkorodudu

Copy link
Copy Markdown
Contributor

Apologies for the delayed response, I just got back from holiday and I’m also surprised to see Vercel asking for deployment approval. I haven’t changed any settings, and approving it doesn’t seem to do anything. Following the conversation on Slack, I agree to wait until the SG call to discuss this. Thanks @demiankatz for taking the time to address this issue, hopefully once the Vercel issue is sorted, I’ll be able to test this fix.

@demiankatz

Copy link
Copy Markdown
Contributor Author

Apologies for the delayed response, I just got back from holiday and I’m also surprised to see Vercel asking for deployment approval. I haven’t changed any settings, and approving it doesn’t seem to do anything. Following the conversation on Slack, I agree to wait until the SG call to discuss this. Thanks @demiankatz for taking the time to address this issue, hopefully once the Vercel issue is sorted, I’ll be able to test this fix.

Thanks, @LanieOkorodudu, this is very strange. Might it be worth reaching out to Vercel support to see if they can figure out what has changed? I'm happy to work on troubleshooting this during SG, but since that's not until the 15th, and we were hoping to put out a release candidate on the 20th, that doesn't give us a whole lot of time to get this done if we want to include the fix in the release -- it might be good to at least investigate some options ahead of time. (I'm also happy to work with you on this over Slack if that helps, though since I don't have access to Vercel admin, my options are presently limited).

@edsilv did try to adjust the Node version used by Vercel in case that was the problem, but it doesn't seem to have made a difference. I'm not sure how to re-trigger the action without making additional commits, though, which is a bit unfortunate!

@erinburnand

Copy link
Copy Markdown

Hi Demian, would it be helpful to add you as a team member to the vercel account?

@demiankatz

Copy link
Copy Markdown
Contributor Author

@erinburnand, if you have a seat available, I'm certainly willing to take a look -- but I'm not familiar with the workings of Vercel, so I'm really not sure how much help I would be. Or to put it another way, if there's room for me, by all means, but if it's going to incur extra costs, maybe we should wait and make sure it's worth it.

@erinburnand

Copy link
Copy Markdown

I think costs will be minimal, and team seats are easy to remove if it turns out there is no benefit. @LanieOkorodudu would you mind adding Demian to the team?

@demiankatz

Copy link
Copy Markdown
Contributor Author

Superseded by #1543.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

4 participants